Awesome !marctdt wrote:Ok I ll do that.
Well i didn't really fixed it, because first the feature is a bit different than what was intended and I kind of just patched on the top of the issue instead of really fixing it.
But I know why it is not working, here a quick explanation:
If I understand properly the function duplicate_clip() is supposed to be triggered by(https://github.com/hdavid/Launchpad_Pro ... ent.py#L89)Code: Select all
@duplicate_button.pressed def duplicate_button(self, button): if self.can_perform_clip_action(): clip = self.get_clip() duplicate_clip(self.song(), clip.canonical_parent, should_launch=True)
which have the parameter "should_launch" set to True.
But in fact Duplicate_Button.pressed is never called and is triggered by(https://github.com/hdavid/Launchpad_Pro ... ent.py#L74)Code: Select all
def _do_duplicate_clip(self): if self._clip_slot: duplicate_clip(self.song(), self._clip_slot)
which keep "should_launch" to False
I don't know why Duplicate_Button.pressed is not triggered, and I was not able to understand what "should_launch" is doing. When "should_launch" is False, the function doesn't seems to do anything.
i merged the pull request and released an update.
thanks a bunch